-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: generate proper hint for IndexHashJoin / IndexMergeJoin #20992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
This PR fixes a bug.
sig/planner
SIG: Planner
needs-cherry-pick-4.0
epic/sql-plan-management
labels
Nov 11, 2020
eurekaka
requested review from
winoros and
qw4990
and removed request for
XuHuaiyu
November 11, 2020 12:07
winoros
reviewed
Nov 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closed
lzmhhh123
previously approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
previously approved these changes
Nov 12, 2020
/run-all-tests |
1 similar comment
/run-all-tests |
lzmhhh123
approved these changes
Nov 12, 2020
cherry pick to release-4.0 in PR #21020 |
eurekaka
added a commit
to eurekaka/tidb
that referenced
this pull request
Nov 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
epic/sql-plan-management
sig/planner
SIG: Planner
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #20991
Problem Summary:
The join hint generated by
explain format = 'hint'
would not work if the join is index hash join or index merge join.What is changed and how it works?
What's Changed:
inl_merge_join
/inl_hash_join
TableOptimizerHint;Related changes
Check List
Tests
Side effects
N/A
Release note